Martin Peřina has posted comments on this change. Change subject: webadmin: Save PM options even when PM disabled ......................................................................
Patch Set 1: You were right, I tested only valid values and with them this patch works fine. But for example if I put 'x' into port number, validation stops saving when PM is turned on. And if PM is turned off, validation is also turned off and the "bad" value is saved into db, because these options are saved as string. On the other hand saving values without validation works also for other fields untouched by this patch. For example if PM is on, you cannot save PM options with empty user name. But you can save it if PM is off. Anyway we shall unify this behavior somehow: 1) If PM is off, then during save all PM options should be set to null (this seem more logical for me) 2) Or use this patch and have same behavior for all PM options (this means save values without validation when PM is off) Maybe it's also question for UX team, how this is handled in other part of webadmin ... -- To view, visit http://gerrit.ovirt.org/29593 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iccc3121e35c05123a110f98802bb548034aaa308 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
