Einav Cohen has posted comments on this change. Change subject: frontend: login: split user@domain ......................................................................
Patch Set 2: > imo we need this fix because we cannot use browser's cookie to save > user+domain anymore, means you'll need to select the domain as well -> imo > really annoying (especially if you're used to it in previous versions). Gilad, assuming that the user is typically logging in with the same user/password/domain, he only needs to select the Domain once (in his first login) - in the login actions afterwards, the same Domain will be pre-selected for him, since it is saved (and retrieved) in (from) a cookie. please see my comment #32 in BZ#1112252. we need to: - have the Domain drop-down *always* enabled. - send user, password, domain values to the engine as-is. If this patch does not do the above, please re-write it or abandon it. thanks. -- To view, visit http://gerrit.ovirt.org/29613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie74a9b0d74b081c4966a26a5d9de1598c91fac51 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
