Gilad Chaplik has posted comments on this change. Change subject: restapi: add QoS RESTful interface for storage QoS ......................................................................
Patch Set 17: (1 comment) http://gerrit.ovirt.org/#/c/27097/17/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQossResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQossResource.java: Line 63: @Override Line 64: protected Response performRemove(String id) { Line 65: QosParametersBase<?> params = new QosParametersBase<>(); Line 66: params.setQosId(GuidUtils.asGuid(id)); Line 67: return performAction(VdcActionType.RemoveStorageQos, params); > imo this should be a general remove and not a storage qos remove, does it m right. you can do it when extending to your qos Line 68: } Line 69: Line 70: @Override Line 71: @SingleEntityResource -- To view, visit http://gerrit.ovirt.org/27097 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a9af59277b50554531522802f19046c0051d82f Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
