Arik Hadas has posted comments on this change.

Change subject: core: clear migrating_to_vds after successful migration
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/29620/4/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDynamicDAOTest.java
File 
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDynamicDAOTest.java:

Line 164: 
Line 165:         dao.clearMigratingToVds(vmId);
Line 166: 
Line 167:         vmDynamic = dao.get(vmId);
Line 168:         assertNull("migrating_to_vds field should not be null after 
we clear it",
> should or should not be null? that is the question
should, Shakespeare :)
Line 169:                 vmDynamic.getMigratingToVds());
Line 170:     }


-- 
To view, visit http://gerrit.ovirt.org/29620
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb4c73eba707551259cdfc3ca6cacb7b61ff5594
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to