Omer Frenkel has posted comments on this change. Change subject: dal: Refactor VmStatic and VmTemplate Daos ......................................................................
Patch Set 2: Code-Review+1 (2 comments) looks ok, one question inside http://gerrit.ovirt.org/#/c/29544/2/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmBaseDaoDbFacade.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmBaseDaoDbFacade.java: Line 16: Line 17: import java.sql.ResultSet; Line 18: import java.sql.SQLException; Line 19: Line 20: public abstract class VmBaseDaoDbFacade<T extends VmBase> extends DefaultGenericDaoDbFacade<T, Guid> { name should be VmBaseDaoDbFacadeImpl Line 21: public VmBaseDaoDbFacade(String entityStoredProcedureName) { Line 22: super(entityStoredProcedureName); Line 23: } Line 24: http://gerrit.ovirt.org/#/c/29544/2/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java: Line 218 Line 219 Line 220 Line 221 Line 222 this is not needed anymore? no need to do declare the stored procedure name somewhere? -- To view, visit http://gerrit.ovirt.org/29544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8c02c11ededf4dfba67e5cc8598ae90155d7eb5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
