Yair Zaslavsky has posted comments on this change.

Change subject: aaa: change groupNames to be a set
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/29582/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUser.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUser.java:

Line 91:         lastName = ldapUser.getSurName();
Line 92:         department = ldapUser.getDepartment();
Line 93:         email = ldapUser.getEmail();
Line 94:         active = true;
Line 95:         groupNames = new 
HashSet<String>(Arrays.asList(ldapUser.getGroup().split(",")));
> always split by .trim().split(" *, *")
Done
Line 96:         role = "";
Line 97:         note = "";
Line 98:     }
Line 99: 


-- 
To view, visit http://gerrit.ovirt.org/29582
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0e6151cade614446f6343c579ed572754e09db2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to