Juan Hernandez has posted comments on this change. Change subject: tools: More information in time_diff file ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) .................................................... File src/rhev/logcollector.py Line 382: I would suggest to change the names to something easier to understand: What about TIME_DRIFT_FORMAT and TIME_DRIFT_HEADER? -- To view, visit http://gerrit.ovirt.org/5784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iedac60d0dbefb99c610892ea616c996a7c9dce62 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Keith Robertson <krobe...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Lee Yarwood <lyarw...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
