Moti Asayag has posted comments on this change. Change subject: core: filter vds with no required network in vdsselector (#826593) ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java Line 131: .getAllVdsForVM(getVm().getId())); how about passing here cluster id and list of required networks ? than retrieving the data will be simpler. It will require parsing of the network names list on the stored procedure, but all really needed here are 2 stored procedure invocation: * Fetching the vm interfaces (if weren't loaded yet) for the sake of network names * Fetching the hosts for a given cluster id which have interfaces for the provided list of networks (join between vds_static to to vds_interfaces). -- To view, visit http://gerrit.ovirt.org/5754 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd06d9a4ecdf0499d7c241d0571ed17af0cd2900 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
