Mike Kolesnik has posted comments on this change. Change subject: engine: Validate network provider properties ......................................................................
Patch Set 8: Code-Review-1 (1 comment) Please make sure to add tests to the validator http://gerrit.ovirt.org/#/c/29520/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java: Line 111: // This is due to permission check that must be done both on Line 112: // the VDS and on the VDSGroup Line 113: addCanDoActionMessage(VdcBllMessages.VDS_CANNOT_UPDATE_CLUSTER); Line 114: } else if (getParameters().getInstallVds() && getParameters().getNetworkProviderId() != null) { Line 115: if (returnValue && getParameters().getNetworkProviderId() != null) { Since returnValue is intially false, don't see how it can be true here.. Line 116: returnValue = validateNetworkProviderProperties(getParameters().getNetworkProviderId(), Line 117: getParameters().getNetworkMappings()); Line 118: } Line 119: } else { -- To view, visit http://gerrit.ovirt.org/29520 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idcdcddb9694426c1e656c9fa1e04dc7f37e8115c Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
