Juan Hernandez has posted comments on this change. Change subject: webadmin: Use an absolute URL for spice CABs ......................................................................
Patch Set 2: (2 inline comments) I am rebasing the change, but can't remove the servlet-per-file thing yet, as the /usr/share/spice directory may contain other unrelated files. I intend to add new parameters to the file servlet in the future to support this: include: a regex of files allowed exclude: a regex of files not allowed I will revisit this once those parameters are added. .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java Line 291: * <code>http://www.example.com:800</code>. Done Line 301: index = moduleURL.indexOf("/", index + 3); //$NON-NLS-1$ Done -- To view, visit http://gerrit.ovirt.org/5612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id22b30f8120e281187572b164b88fa9c260f61dd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
