Douglas Schilling Landgraf has posted comments on this change. Change subject: packaging: add version information ......................................................................
Patch Set 1: (3 comments) Thank you alon, sending my feedback. http://gerrit.ovirt.org/#/c/29562/1/ovirt-node-plugin-vdsm.spec.in File ovirt-node-plugin-vdsm.spec.in: Line 1: %define is_f19 %(test "0%{?fedora}" -eq "019" && echo 1 || echo 0) Line 2: Line 3: Summary: A plugin to make oVirt Node installs compatible with oVirt Engine and vdsm Line 4: Name: ovirt-node-plugin-vdsm Line 5: Version: @RPM_VERSION@ Probably @PACKAGE_RPM_VERSION@ ? Line 6: Release: @RPM_RELEASE@%{?BUILD_NUMBER}%{?extra_release}%{?dist} Line 7: Source0: %{name}-%{version}.tar.gz Line 8: License: GPLv2+ Line 9: Group: Applications/System Line 2: Line 3: Summary: A plugin to make oVirt Node installs compatible with oVirt Engine and vdsm Line 4: Name: ovirt-node-plugin-vdsm Line 5: Version: @RPM_VERSION@ Line 6: Release: @RPM_RELEASE@%{?BUILD_NUMBER}%{?extra_release}%{?dist} Probably @PACKAGE_RPM_RELEASE@ ? Line 7: Source0: %{name}-%{version}.tar.gz Line 8: License: GPLv2+ Line 9: Group: Applications/System Line 10: Line 3: Summary: A plugin to make oVirt Node installs compatible with oVirt Engine and vdsm Line 4: Name: ovirt-node-plugin-vdsm Line 5: Version: @RPM_VERSION@ Line 6: Release: @RPM_RELEASE@%{?BUILD_NUMBER}%{?extra_release}%{?dist} Line 7: Source0: %{name}-%{version}.tar.gz We need to update the Source here to match _master (ovirt-node-plugin-vdsm-0.2.0_master.tar.gz) schema. Line 8: License: GPLv2+ Line 9: Group: Applications/System Line 10: Line 11: BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-buildroot -- To view, visit http://gerrit.ovirt.org/29562 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3743ef37e804137e2a3517180a67c5fb1a6cecbc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabi...@fedoraproject.org> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
