Yaniv Bronhaim has posted comments on this change. Change subject: ui: Adding base class for external entity objects ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/29372/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalEntityBase.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalEntityBase.java: Line 1: package org.ovirt.engine.core.common.businessentities; Line 2: Line 3: import java.io.Serializable; Line 4: Line 5: public interface ExternalEntityBase extends Serializable { > please add a serialVersionUID constant each concrete class adds it as private long, the interface shouldn't declare it Line 6: public abstract String getDescription(); Line 7: public abstract String getName(); http://gerrit.ovirt.org/#/c/29372/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java: Line 818: { Line 819: privateExternalHostName = value; Line 820: } Line 821: Line 822: private ListModel<ExternalEntityBase> privateExternalDiscoveredHosts; > please remember to format the getters/setters http://gerrit.ovirt.org/29548 Line 823: Line 824: public ListModel<ExternalEntityBase> getExternalDiscoveredHosts() { return privateExternalDiscoveredHosts; } Line 825: Line 826: protected void setExternalDiscoveredHosts(ListModel<ExternalEntityBase> value) { privateExternalDiscoveredHosts = value; } -- To view, visit http://gerrit.ovirt.org/29372 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieedfa9efcd062c3a4a41250fee0a8b1a22844ff6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
