Gilad Chaplik has posted comments on this change. Change subject: webadmin: add buttons in the new cluster dialog and make it closeable ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/28380/2//COMMIT_MSG Commit Message: Line 15: The codes that add buttons in the dialog were inside a Line 16: async-callback method.(This callback method is used to Line 17: set the data center list of the dialog after query from Line 18: the database.) This is unreasonable. The codes should be Line 19: outside the callback method.This patch fixed the problem. > i have different opinion. no matter the data was prepared or not the button we prefer to fix all bugs, and setting the commands at the end gives us a good idea that the flow is okay. anyway there's still an exception, fix that and the buttons will appear :) Line 20: Line 21: Change-Id: I33802bc7d3a703e6b15b7674a8255a50cf34e4f0 Line 22: Bug-Url: https://bugzilla.redhat.com/1079180 -- To view, visit http://gerrit.ovirt.org/28380 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33802bc7d3a703e6b15b7674a8255a50cf34e4f0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Malike <like...@cs2c.com.cn> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Malike <like...@cs2c.com.cn> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
