Hello Shahar Havivi,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/29496

to review the following change.

Change subject: API: Interface name is not set via cloud-init api
......................................................................

API: Interface name is not set via cloud-init api

Change-Id: I2108863d9ac1463d72b5b5fb139a04fba0f99b0d
Bug-Url: https://bugzilla.redhat.com/1115389
Signed-off-by: Shahar Havivi <shah...@redhat.com>
(cherry picked from commit 42efda3be3c36e0785d114269bcc2b3660c4a138)
---
M 
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/96/29496/1

diff --git 
a/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
 
b/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
index 3067a15..1a25331 100644
--- 
a/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
+++ 
b/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
@@ -7,7 +7,6 @@
 import java.util.List;
 import java.util.Map;
 import java.util.Set;
-
 import org.apache.commons.lang.StringUtils;
 import org.ovirt.engine.api.common.util.StatusUtils;
 import org.ovirt.engine.api.model.AuthorizedKey;
@@ -1155,6 +1154,9 @@
                 List<VmInitNetwork> interfaces = new 
ArrayList<VmInitNetwork>();
                 for (NIC iface : 
model.getNetworkConfiguration().getNics().getNics()) {
                     VmInitNetwork vmInitInterface = new VmInitNetwork();
+                    if (iface.isSetName()) {
+                        vmInitInterface.setName(iface.getName());
+                    }
                     interfaces.add(vmInitInterface);
                     if (iface.isSetBootProtocol()) {
                         NetworkBootProtocol protocol = BootProtocolMapper.map


-- 
To view, visit http://gerrit.ovirt.org/29496
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2108863d9ac1463d72b5b5fb139a04fba0f99b0d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to