Liron Aravot has uploaded a new change for review. Change subject: core: RetrieveImageData headers - use range instead of size ......................................................................
core: RetrieveImageData headers - use range instead of size On patch http://gerrit.ovirt.org/#/c/28465/ the Size header is being replaced with the standart Range header in GET requests for downloading image data - this patch changes the engine to use the Range header as well. Change-Id: Ie15ad8b48c24d3983ae352f719267356eea16572 Signed-off-by: Liron Aravot <[email protected]> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/RetrieveImageDataVDSCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/81/29481/1 diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/RetrieveImageDataVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/RetrieveImageDataVDSCommand.java index 5294c91..76f8e69 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/RetrieveImageDataVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/RetrieveImageDataVDSCommand.java @@ -14,7 +14,7 @@ } protected void prepareMethod() { - getMethod().setRequestHeader("Size", getParameters().getSize().toString()); + getMethod().setRequestHeader("Range", String.format("bytes=0-%s", getParameters().getSize() - 1)); } @Override @@ -54,6 +54,6 @@ @Override protected int getSuccessCode() { - return HttpStatus.SC_OK; + return HttpStatus.SC_PARTIAL_CONTENT; } } -- To view, visit http://gerrit.ovirt.org/29481 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie15ad8b48c24d3983ae352f719267356eea16572 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
