Lior Vernia has posted comments on this change. Change subject: core: MacPool related Commands ......................................................................
Patch Set 16: (1 comment) http://gerrit.ovirt.org/#/c/28705/16/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MacPoolValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MacPoolValidator.java: Line 35: Line 36: private boolean macPoolNameUnique(String name) { Line 37: final List<MacPool> macPools = getMacPoolDao().getAll(); Line 38: for (MacPool pool : macPools) { Line 39: if (pool.getName().equals(name)) { > I suspect that in case of updating the mac pool this would fail, as it alre Indeed, just failed on this when testing GUI. Line 40: return false; Line 41: } Line 42: } Line 43: -- To view, visit http://gerrit.ovirt.org/28705 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c0c3657e3e53699bcafa375befdce848b01a2f3 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
