Vojtech Szocs has posted comments on this change. Change subject: webadmin: Fix server-side sort issue ......................................................................
Patch Set 5: (1 comment) Lior, please see my answer and let me know what you think. http://gerrit.ovirt.org/#/c/28557/5/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java: Line 239: table.enableColumnWidthPersistence(clientStorage, dataProvider.getModel()); Line 240: } Line 241: Line 242: // When UiCommon models are (re)initialized, register search string change listener Line 243: eventBus.addHandler(UiCommonInitEvent.getType(), new UiCommonInitHandler() { > > Do these tables exist for the entire login session of the user? To summarize my above comment: logical scope of AbstractActionTable widget is the same as logical scope of corresponding SearchableListModel - UI login session for the given user. (In practice, the scope of AbstractActionTable widget is typically the same as logical scope of GWTP View which is application-wide singleton in most cases.) Therefore I'd like to preserve current approach, which is sensitive to UiCommonInitEvent (triggered on login after all models are re-initialized). Line 244: @Override Line 245: public void onUiCommonInit(UiCommonInitEvent event) { Line 246: addModelSearchStringChangeListener(dataProvider.getModel()); Line 247: } -- To view, visit http://gerrit.ovirt.org/28557 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ce39a4e2b6323e6e0276a3a462a3f9da005344b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
