Eli Mesika has posted comments on this change. Change subject: core: handle fence agent power wait param on stop ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/29383/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java: Line 472: final String FENCE_CMD = (actionType == FenceActionType.Start) ? "on" : "off"; Line 473: final String ACTION_NAME = actionType.name().toLowerCase(); Line 474: int i = 1; Line 475: boolean statusReached = false; Line 476: log.infoFormat("Waiting for vds {0} to {1}", vdsName, ACTION_NAME); > put some spacing here before the comment. Done Line 477: // Waiting before first attempt to check the host status. Line 478: // This is done because if we will attempt to get host status immediately Line 479: // in most cases it will not turn from on/off to off/on and we will need Line 480: // to wait a full cycle for it. http://gerrit.ovirt.org/#/c/29383/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java: Line 1843: /** Line 1844: * Defines the parameter name used by the agent script to delay host on/off Line 1845: */ Line 1846: @TypeConverterAttribute(String.class) Line 1847: @DefaultValueAttribute("apc=power_wait,apc_snmp=power_wait,bladecenter=power_wait,cisco_ucs=power_wait,drac5=power_wait,drac7=power_wait,eps=delay,hpblade=power_wait,ilo=power_wait,ilo2=power_wait,ilo3=power_wait,ilo4=power_wait,ipmilan=power_wait,rsa=power_wait,rsb=power_wait,wti=power_wait") > do they all have power wait, and it is called power_wait? No , see in eps it is called "delay" Line 1848: FencePowerWaitParam, Line 1849: Line 1850: /** Line 1851: * Defines the parameter name used by the custom agent script to delay host on/off -- To view, visit http://gerrit.ovirt.org/29383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I310e076ecf84988cacd0b179954d2460d7988b91 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
