Daniel Erez has uploaded a new change for review.
Change subject: webadmin: column sorting support for Disks sub-tabs
......................................................................
webadmin: column sorting support for Disks sub-tabs
Enabled column sorting for sub-tabs under Disks main-tab.
ToDo: sorting support for PercentColumn and StatusColumn.
Change-Id: Ief020f9f87c7ccdd92fbdd1802a121b1c08c2579
Signed-off-by: Daniel Erez <de...@redhat.com>
---
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskStorageView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskTemplateView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskVmView.java
3 files changed, 17 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/77/29377/1
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskStorageView.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskStorageView.java
index b8d8f7b..1310cf5 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskStorageView.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskStorageView.java
@@ -48,6 +48,7 @@
return object.getStorageName();
}
};
+ nameColumn.makeSortable();
getTable().addColumn(nameColumn, constants.domainNameStorage(),
"160px"); //$NON-NLS-1$
TextColumnWithTooltip<StorageDomain> typeColumn = new
EnumColumn<StorageDomain, StorageDomainType>() {
@@ -56,6 +57,7 @@
return object.getStorageDomainType();
}
};
+ typeColumn.makeSortable();
getTable().addColumn(typeColumn, constants.domainTypeStorage(),
"160px"); //$NON-NLS-1$
TextColumnWithTooltip<StorageDomain> statusColumn = new
EnumColumn<StorageDomain, StorageDomainStatus>() {
@@ -64,6 +66,7 @@
return object.getStatus();
}
};
+ statusColumn.makeSortable();
getTable().addColumn(statusColumn, constants.statusStorage(),
"160px"); //$NON-NLS-1$
DiskSizeColumn<StorageDomain> freeColumn = new
DiskSizeColumn<StorageDomain>(SizeConverter.SizeUnit.GB) {
@@ -73,6 +76,7 @@
return (long) availableDiskSize;
}
};
+ freeColumn.makeSortable();
getTable().addColumn(freeColumn, constants.freeSpaceStorage(),
"160px"); //$NON-NLS-1$
DiskSizeColumn<StorageDomain> usedColumn = new
DiskSizeColumn<StorageDomain>(SizeConverter.SizeUnit.GB) {
@@ -82,6 +86,7 @@
return (long) usedDiskSize;
}
};
+ usedColumn.makeSortable();
getTable().addColumn(usedColumn, constants.usedSpaceStorage(),
"160px"); //$NON-NLS-1$
DiskSizeColumn<StorageDomain> totalColumn = new
DiskSizeColumn<StorageDomain>(SizeConverter.SizeUnit.GB) {
@@ -91,6 +96,7 @@
return (long) totalDiskSize;
}
};
+ totalColumn.makeSortable();
getTable().addColumn(totalColumn, constants.totalSpaceStorage(),
"160px"); //$NON-NLS-1$
TextColumnWithTooltip<StorageDomain> descriptionColumn = new
TextColumnWithTooltip<StorageDomain>() {
@@ -99,6 +105,7 @@
return object.getDescription();
}
};
+ descriptionColumn.makeSortable();
getTable().addColumn(descriptionColumn,
constants.domainDescriptionStorage(), "160px"); //$NON-NLS-1$
}
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskTemplateView.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskTemplateView.java
index e19145f..1b4ad41 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskTemplateView.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskTemplateView.java
@@ -43,6 +43,7 @@
return object.getName();
}
};
+ nameColumn.makeSortable();
getTable().addColumn(nameColumn, constants.nameTemplate(), "200px");
//$NON-NLS-1$
TextColumnWithTooltip<VmTemplate> disksColumn = new
TextColumnWithTooltip<VmTemplate>() {
@@ -51,6 +52,7 @@
return String.valueOf(object.getDiskTemplateMap().size());
}
};
+ disksColumn.makeSortable();
getTable().addColumn(disksColumn, constants.disksTemplate(), "200px");
//$NON-NLS-1$
DiskSizeColumn<VmTemplate> sizeColumn = new
DiskSizeColumn<VmTemplate>() {
@@ -59,7 +61,7 @@
return Double.valueOf(object.getActualDiskSize()).longValue();
}
};
-
+ sizeColumn.makeSortable();
getTable().addColumn(sizeColumn, constants.actualSizeTemplate(),
"200px"); //$NON-NLS-1$
FullDateTimeColumn<VmTemplate> dateColumn = new
FullDateTimeColumn<VmTemplate>() {
@@ -68,6 +70,7 @@
return object.getCreationDate();
}
};
+ dateColumn.makeSortable();
getTable().addColumn(dateColumn, constants.creationDateTemplate(),
"200px"); //$NON-NLS-1$
}
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskVmView.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskVmView.java
index e68ed51..5e8cc82 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskVmView.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskVmView.java
@@ -56,6 +56,7 @@
return object.getName();
}
};
+ nameColumn.makeSortable();
getTable().addColumn(nameColumn, constants.nameVm(), "140px");
//$NON-NLS-1$
getTable().addColumn(new VmTypeColumn(), constants.empty(), "30px");
//$NON-NLS-1$
@@ -66,6 +67,7 @@
return object.getVdsGroupName();
}
};
+ clusterColumn.makeSortable();
getTable().addColumn(clusterColumn, constants.clusterVm(), "140px");
//$NON-NLS-1$
TextColumnWithTooltip<VM> ipColumn = new TextColumnWithTooltip<VM>() {
@@ -74,6 +76,7 @@
return object.getVmIp();
}
};
+ ipColumn.makeSortable();
getTable().addColumn(ipColumn, constants.ipVm(), "140px");
//$NON-NLS-1$
TextColumnWithTooltip<VM> fqdnColumn = new TextColumnWithTooltip<VM>()
{
@@ -82,6 +85,7 @@
return object.getVmFQDN();
}
};
+ fqdnColumn.makeSortable();
getTable().addColumn(fqdnColumn, constants.fqdn(), "140px");
//$NON-NLS-1$
PercentColumn<VM> memColumn = new PercentColumn<VM>() {
@@ -114,6 +118,7 @@
return object.getStatus();
}
};
+ statusColumn.makeSortable();
getTable().addColumn(statusColumn, constants.statusVm(), "140px");
//$NON-NLS-1$
TextColumnWithTooltip<VM> hostColumn = new UptimeColumn<VM>() {
@@ -122,6 +127,7 @@
return object.getRoundedElapsedTime();
}
};
+ hostColumn.makeSortable();
getTable().addColumn(hostColumn, constants.uptimeVm(), "140px");
//$NON-NLS-1$
}
--
To view, visit http://gerrit.ovirt.org/29377
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief020f9f87c7ccdd92fbdd1802a121b1c08c2579
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
