Lior Vernia has posted comments on this change. Change subject: core: MacPoolManager-->ScopedMacPoolManager ......................................................................
Patch Set 38: (1 comment) Please see inline comment. http://gerrit.ovirt.org/#/c/26800/38/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java: Line 303: return checkFreeSpaceAndTypeOnDestDomains(); Line 304: } Line 305: Line 306: protected boolean verifyAddVM() { Line 307: final MacPoolManagerStrategy macPool = getMacPoolForVm(); This generates a null pointer exception when in MacPoolPerDc.poolForVm() when I try to create a new VM pool. Line 308: final List<String> reasons = getReturnValue().getCanDoActionMessages(); Line 309: final int nicsCount = getParameters().getVmsCount() Line 310: * getVmNicDao().getAllForTemplate(getVmTemplateId()).size(); Line 311: final int priority = getParameters().getVmStaticData().getPriority(); -- To view, visit http://gerrit.ovirt.org/26800 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I779f4d031409fbc422077ddf291fa34f955f3206 Gerrit-PatchSet: 38 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
