Alona Kaplan has posted comments on this change. Change subject: webadmin: Add common MAC pool widget ......................................................................
Patch Set 11: (3 comments) http://gerrit.ovirt.org/#/c/27790/11/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/macpool/MacPoolModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/macpool/MacPoolModel.java: Line 62: range1 Can you please explain this sort? I don't really understand it... http://gerrit.ovirt.org/#/c/27790/11/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/macpool/MacRangeModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/macpool/MacRangeModel.java: Line 50: IValidation Please extract the validator to a separate class. http://gerrit.ovirt.org/#/c/27790/11/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/macpool/MacRangeEditor.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/macpool/MacRangeEditor.java: Line 68: addKeyDownHandler This is not the first time I see that KeyDown triggers ValueChagnedEvent. I suggest to add this code to AbstractValueBoxWithLabelEditor. In order to prevent unexpected behaviour in old usages of the editor you can add a method shouldKeyDownTriggerValueChange() that by default returns false. After the change please fix all the other occurrences of this code. -- To view, visit http://gerrit.ovirt.org/27790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife55cf7c5e005912639c087565c3c5c3faddd93d Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
