Yair Zaslavsky has posted comments on this change. Change subject: aaa: adding correlation Id arguments at IrsBroker and VdsBroker This is the first patch towards removing corelation id from ThreadLocal. ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/29366/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtils.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtils.java: Line 311: Line 312: @Override Line 313: public Object sendRequest(XmlRpcRequest pRequest) throws XmlRpcException { Line 314: return super.sendRequest(new CustomXmlRpcRequest(pRequest)); Line 315: } > I liked the previous implementation more, as it shows the way into http-1.1 Well, are we going to suppport xml rpc in the future? I thought we're supposed to move to json / STOMP Line 316: Line 317: }; Line 318: Line 319: /** -- To view, visit http://gerrit.ovirt.org/29366 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I828ad7a6e6ba64ed59bd935f500a9ed008244d6f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches