Martin Peřina has posted comments on this change. Change subject: host-deploy: appropriate message for kdump detection ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29369/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java: Line 574: new Callable<Boolean>() { public Boolean call() throws Exception { Line 575: if (_vds.isPmKdumpDetection() && !fenceKdumpSupported) { Line 576: _messages.post( Line 577: InstallerMessages.Severity.INFO, Line 578: "Disabling Kdump support" I prefer previous message (without exclamation): 1) Kdump itself worked fine even with previous version of kexec-tools 2) We are trying to install and configure kdump detection 3) Kdump detection is automatically turned on for all new hosts in oVirt 3.5, so it's supposed to be functional on all new hosts. It's more meaningfull for me this message to be a warning Line 579: ); Line 580: } Line 581: Line 582: _parser.cliEnvironmentSet( -- To view, visit http://gerrit.ovirt.org/29369 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie10ebdbbc0b5148e4cd6e1b2deb251f96a2f56c7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
