Omer Frenkel has submitted this change and it was merged. Change subject: core: NPE on UpdateVmCommand when deleting a cdrom from a VM using REST ......................................................................
core: NPE on UpdateVmCommand when deleting a cdrom from a VM using REST The problem was that the getParameters().isBalloonEnabled() is a Boolean and was not set (e.g. it was null) causing a NPE on autoboxing to boolean in checkPciAndIdeLimit(). Fixed the same way as all the other devices are done (e.g. isVirtioScsiEnabled()). Change-Id: Ib9f9d6e47dd90d2501b43587532235d14928aa64 Signed-off-by: Tomas Jelinek <tjeli...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29353 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9f9d6e47dd90d2501b43587532235d14928aa64 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches