Tomas Jelinek has posted comments on this change.

Change subject: ui: remove Escape characters for TextBoxLabel
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/29292/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/TextBoxLabel.java
File 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/TextBoxLabel.java:

Line 15:     public TextBoxLabel() {
Line 16:         super(new EmptyValueRenderer<String>() {
Line 17:             @Override
Line 18:             public String render(String value) {
Line 19:                 String renderedText = super.render(value);
in case you are removing the SafeHtmlUtils.htmlEscape(renderedText); you do not 
need to override the render() method. Please use only:
super(new EmptyValueRenderer<String>());
Line 20:                 return renderedText;
Line 21:             }
Line 22:         });
Line 23:     }


-- 
To view, visit http://gerrit.ovirt.org/29292
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e303decb9395fcf193e874b4ae55ab076ec0bba
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to