Vinzenz Feenstra has posted comments on this change. Change subject: Add OS info reporting ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/28938/3/ovirt-guest-agent/GuestAgentLinux2.py File ovirt-guest-agent/GuestAgentLinux2.py: Line 219: Line 220: def getOsVersion(self): Line 221: return os.uname()[2] Line 222: Line 223: def getOsInfo(self): > we don't need to get the info every time we send data…in fact it should be Ok so I will change it to send on refresh and startup. Line 224: cmd = [_get_script_path('ovirt-osinfo')] Line 225: logging.debug('Executing ovirt-osinfo command: %s', cmd) Line 226: result = { Line 227: 'version': '', -- To view, visit http://gerrit.ovirt.org/28938 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I682fd9683cf9e4b392ecd4824e4a9526bf7e5e59 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
