Alon Bar-Lev has posted comments on this change. Change subject: kdump: Fix version comparisons ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/29317/4/src/plugins/ovirt-host-deploy/kdump/packages.py File src/plugins/ovirt-host-deploy/kdump/packages.py: Line 165: if min_version is not None: Line 166: from rpmUtils.miscutils import compareEVR Line 167: result = self.packager.queryPackages( Line 168: patterns=(self._KEXEC_TOOLS_PKG,), Line 169: ) return to original? Line 170: self.logger.debug("minver: %s, result=%s", min_version, result) Line 171: for package in result: Line 172: cur_version = ( Line 173: None, Line 171: for package in result: Line 172: cur_version = ( Line 173: None, Line 174: package['version'], Line 175: package['release'] re-add the comma? Line 176: ) Line 177: if compareEVR(cur_version, min_version) >= 0: Line 178: self.environment[odeploycons.KdumpEnv.SUPPORTED] = True Line 179: break -- To view, visit http://gerrit.ovirt.org/29317 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica14bd688c73a511ad8d7557231cff2e184830a9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
