Yair Zaslavsky has posted comments on this change. Change subject: aaa: more fixes to command context propgation ......................................................................
Patch Set 4: i understand that that we need to inherit context. i am in favor. i asked what do u plan to do if we need more attributes to be passed not via the entire engine flow, for example- only at commands (not to queries, not to vds broker) - will you add to command context? add something? I thought that the meaning of EngineContext is to have a context that will be "alive" in the entire flow. this is why i thought it makes sense to reset everything besides that. once again, i feel the "detach" is too obscure.. detach of what? -- To view, visit http://gerrit.ovirt.org/29290 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbf9e0216c83d981d11bb2d8d2a939fd2a279d9d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
