Michal Skrivanek has posted comments on this change. Change subject: core: enable hyperv optimization on windows ......................................................................
Patch Set 4: (1 comment) I'd like to hear from Roy... http://gerrit.ovirt.org/#/c/29238/4/packaging/conf/osinfo-defaults.properties File packaging/conf/osinfo-defaults.properties: Line 154: os.windows_xp.devices.diskInterfaces.value.3.3 = IDE, VirtIO Line 155: os.windows_xp.devices.diskInterfaces.value.3.4 = IDE, VirtIO Line 156: os.windows_xp.devices.diskInterfaces.value.3.5 = IDE, VirtIO Line 157: os.windows_xp.family.value = windows Line 158: os.windows_xp.devices.hyperv.enabled.value.3.5 = true not sure about the "3.5" part. I'd say in this case it should be kept general as the feature is globally available only in 3.5+ (i.e. the check whether to send anything or not should be done inside engine) I'd like to avoid polluting the file way too much. Roy, what do you think? Line 159: Line 160: Line 161: Line 162: # Windows2003(3, OsType.Windows, false), -- To view, visit http://gerrit.ovirt.org/29238 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01d50a539347211a6729cfb86922d60a6244d495 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
