Alon Bar-Lev has posted comments on this change. Change subject: aaa: adding generateRandom method to EngineContext ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29316/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/EngineContext.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/EngineContext.java: Line 10: } Line 11: Line 12: public static EngineContext generateRandom() { Line 13: return new EngineContext().withSessionId(UUID.randomUUID().toString()); Line 14: } it is not random context... you do not take random... it is just new session. the fact that a new session is created by random is something else... but why a null session id cannot be considered a new session at first get? Line 15: Line 16: public EngineContext(EngineContext engineContext) { Line 17: sessionId = engineContext.sessionId; Line 18: } -- To view, visit http://gerrit.ovirt.org/29316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icee42ef378632b162b6f3058dbd3e0f68a33ade5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
