Ravi Nori has posted comments on this change. Change subject: engine: remove the use of @LockIdNameAttribute ......................................................................
Patch Set 18: (3 comments) http://gerrit.ovirt.org/#/c/25944/18/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 1730: } Line 1731: return lockProperties; Line 1732: } Line 1733: Line 1734: protected boolean acquireLock() { > shouldn't this be final ? is there a case in which we'd like other commands When I make it final unit test fail as Mockito is trying to create a mock for this method doReturn(false).when(command).acquireLock(); I am going to leave it as it is Line 1735: LockProperties lockProperties = getLockProperties(); Line 1736: boolean returnValue = true; Line 1737: if (!Scope.None.equals(lockProperties.getScope())) { Line 1738: releaseLocksAtEndOfExecute = Scope.Execution.equals(lockProperties.getScope()); http://gerrit.ovirt.org/#/c/25944/18/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/LockProperties.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/LockProperties.java: Line 25: */ Line 26: Command, Line 27: /** Line 28: * No lock is required for the command execution Line 29: */ > couldn't we just not set the lock instead of having Scope 'None' ? When we initialized designed this, instead of returning null for no lock it was decided to use None for Lock scope. Line 30: None Line 31: } Line 32: Line 33: /** Line 45: public boolean isWait() { Line 46: return wait; Line 47: } Line 48: Line 49: public LockProperties withWait(boolean wait) { > just a matter of style, but we can replace this one with 2 methods: I need a setter for Json Serialization and deserialization to work. So I think I will leave this as it is, if it is okay. Line 50: this.wait = wait; Line 51: return this; Line 52: } Line 53: -- To view, visit http://gerrit.ovirt.org/25944 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie57e4f7c00ebcd6a4e9e0e61b7d26f50f2d00858 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
