Oved Ourfali has submitted this change and it was merged. Change subject: core: replace regexp validation for user email. ......................................................................
core: replace regexp validation for user email. validating using an ad-hock regexp may cause problems(see bug). using strict java.mail.internetAddress() [1] for validation. This enforces some (but not all) RFC822 syntax. Using the strict form does not allow simple names (e.g 'user') but requires a domain. 'user@localhost' is now accepted. [1] https://javamail.java.net/nonav/docs/api/ Change-Id: I18904a669453baef632af1cd427b61852e7ab583 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1109169 Signed-off-by: Mooli Tayer <mta...@redhat.com> --- M backend/manager/modules/bll/pom.xml M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EventSubscriptionCommandBase.java 2 files changed, 22 insertions(+), 7 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve mooli tayer: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28742 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18904a669453baef632af1cd427b61852e7ab583 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
