Gilad Chaplik has posted comments on this change. Change subject: engine: filter-out already attached disks (#833076) ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/dbscripts/all_disks_sp.sql Line 62: AND (all_disks.vm_guid IS NULL OR all_disks.shareable) do you want me to apply some kind of set theory algebra? it's less readable. (a|b)&(c|a|d) ~= a|(b&(c|d)) -- To view, visit http://gerrit.ovirt.org/5680 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa416fd6cd8e171295458b79322bb654636413f8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
