Maor Lipchuk has posted comments on this change. Change subject: core: introduce GetUnregisteredBlockStorageDomains query ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/29172/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetUnregisteredBlockStorageDomainsQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetUnregisteredBlockStorageDomainsQuery.java: Line 54: Line 55: // Fetch LUNs from GetDeviceList and filter-out irrelevant ones Line 56: List<LUNs> luns = getDeviceList(); Line 57: luns = filterLUNsByTargets(luns, connectedTargets); Line 58: luns = filterLUNsThatBelongToExistingStorageDomains(luns); Using luns might be confusing (before/after filtering) extract 57 and 58 to a new method called "getFilteredLUNs" and add a new variable name filteredLuns Line 59: Line 60: // Retrieve storage domains by VG-IDs extracted from the LUNs Line 61: List<String> vgIDs = getVolumeGroupIdsByLUNs(luns); Line 62: storageDomains = getStorageDomainsByVolumeGroupIds(vgIDs); -- To view, visit http://gerrit.ovirt.org/29172 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71cad5562f8d7dcb39c5a99b7daea28ccb4a00cf Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
