Tomas Jelinek has posted comments on this change.

Change subject: userportal,webadmin: Unable to scroll down template list using 
IE9
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/28939/2/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.java
File 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.java:

Line 213:         }
Line 214: 
Line 215:         MenuBar menuBar = (MenuBar) getSuggestionMenu();
Line 216:         MenuItem item = getSelectedItem(menuBar);
Line 217:         Element toSelect = item.getElement().getParentElement();
> Might want to check for a null item here? Not sure if that is possible or n
Done
Line 218:         toSelect.scrollIntoView();
Line 219:     }
Line 220: 
Line 221:     // extremely ugly - there is just no better way how to find the 
items as MenuItems


-- 
To view, visit http://gerrit.ovirt.org/28939
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I93312c75f7605cb007ae395d900ef8ced35c6b14
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to