Moti Asayag has uploaded a new change for review.
Change subject: engine: Fix null dereference in CommandBase by coverity
......................................................................
engine: Fix null dereference in CommandBase by coverity
CID 1062086 (#1 of 1): Dereference null return value (NULL_RETURNS)
null_method_call: Calling a method on null object
getQuotaConsumptionParameters()
Change-Id: I450d48d0840411db44c95fc15b62eb7ab33be91d
Signed-off-by: Moti Asayag <masa...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/60/29260/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
index 351bc89..572705f 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
@@ -1045,7 +1045,7 @@
List<QuotaConsumptionParameter> consumptionParameters =
getQuotaConsumptionParameters();
if (consumptionParameters != null) {
- for (QuotaConsumptionParameter parameter :
getQuotaConsumptionParameters()) {
+ for (QuotaConsumptionParameter parameter :
consumptionParameters) {
if (parameter.getQuotaGuid() != null &&
!Guid.Empty.equals(parameter.getQuotaGuid())
&&
!QuotaConsumptionParameter.QuotaAction.RELEASE.equals(parameter.getQuotaAction()))
{
quotaPermissionList.add(new
PermissionSubject(parameter.getQuotaGuid(),
--
To view, visit http://gerrit.ovirt.org/29260
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I450d48d0840411db44c95fc15b62eb7ab33be91d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
