Jason Liao has posted comments on this change. Change subject: engine: NUMA feature queries and actions validation ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/27617/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommand.java: Line 38: } Line 39: VM vm = getVm(); Line 40: boolean pinHost = vm.getMigrationSupport() == MigrationSupport.PINNED_TO_HOST; Line 41: Guid vdsId = vm.getDedicatedVmForVds(); Line 42: if (pinHost && vdsId == null) { > please check out ConfigurationValues.java, I want it to be taken from there How to use the ConfigurationValues, do you have document for details, or some code to follow. and why we should set up the configuration here, could explain more ? Line 43: return failCanDoAction(VdcBllMessages.VM_NUMA_PINNED_VDS_NOT_EXIST); Line 44: } Line 45: List<VdsNumaNode> vdsNumaNodes = new ArrayList<>(); Line 46: if (pinHost) { -- To view, visit http://gerrit.ovirt.org/27617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c299405ec5d82ada713ed3d220554bf3055c145 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jason Liao <chuan.l...@hp.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jason Liao <chuan.l...@hp.com> Gerrit-Reviewer: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
