Alon Bar-Lev has posted comments on this change. Change subject: aaa: use runVdsCommand ......................................................................
Patch Set 14: (2 comments) http://gerrit.ovirt.org/#/c/29049/14/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 1939: * know why). Line 1940: */ Line 1941: protected VDSReturnValue runVdsCommand(VDSCommandType commandType, VDSParametersBase parameters) Line 1942: throws VdcBLLException { Line 1943: parameters.setCorrelationId(getCorrelationId()); we still have this in thread local... why is it needed in this patch? Line 1944: return getBackend().getResourceManager().RunVdsCommand(commandType, parameters); Line 1945: } Line 1946: Line 1947: /** http://gerrit.ovirt.org/#/c/29049/14/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSParametersBase.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSParametersBase.java: Line 2: Line 3: public class VDSParametersBase { Line 4: Line 5: private boolean runAsync; Line 6: private String correlationId; is this belong to this patch? anyway... it should go into the context... not the parameters. Line 7: Line 8: public VDSParametersBase() { Line 9: runAsync = true; Line 10: } -- To view, visit http://gerrit.ovirt.org/29049 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idcf48db5ea278a74b1bf87076d3b16af29bb416c Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
