Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: don't rely on priority ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/29197/4/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/core/misc.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/core/misc.py: Line 54 Line 55 Line 56 Line 57 Line 58 > How can we enforce the order between product option questions without prior 1. Priorities do not enfore it either, hence this patch... 2. Not sure we should. Is this so important? 3. otopi sorts functions by name. So we can check carefully the exact sort order and change names (and/or the sort) to make it work as we want 4. If really important we can add to titles other no-op scheduling functions - _cust_prod_opt_end_first_stage, _cust_prod_opt_end_second_stage, ... and add before/after these. -- To view, visit http://gerrit.ovirt.org/29197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I85c0b6f826745b7619517f3cf06a5704b61584e5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
