Tomas Jelinek has uploaded a new change for review.

Change subject: webadmin: NPE on new VM dialog
......................................................................

webadmin: NPE on new VM dialog

The problem was that the VDSGroup.requiredRngSources was marked as final thus
the GWT deserializer inited it to null. Consequently, the
VmModelBehaviorBase.setRngAvailability failed on NPE.

Change-Id: I0eac061be4370cdef57c5c7b466f7a8ec5bcda01
Signed-off-by: Tomas Jelinek <tjeli...@redhat.com>
---
M 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/35/29235/1

diff --git 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java
 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java
index 63612a0..3767d40 100644
--- 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java
+++ 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java
@@ -100,7 +100,7 @@
     @Size(max = BusinessEntitiesDefinitions.VM_SERIAL_NUMBER_SIZE)
     private String customSerialNumber;
 
-    private final Set<VmRngDevice.Source> requiredRngSources;
+    private Set<VmRngDevice.Source> requiredRngSources;
 
     public VDSGroup() {
         migrateOnError = MigrateOnErrorOptions.YES;


-- 
To view, visit http://gerrit.ovirt.org/29235
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0eac061be4370cdef57c5c7b466f7a8ec5bcda01
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to