Liron Aravot has posted comments on this change. Change subject: core: Force detach a storage domain ......................................................................
Patch Set 13: Code-Review+2 (1 comment) Minor comment to look into inside, other than that +2 from me. http://gerrit.ovirt.org/#/c/29021/13/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java: Line 110: "The meta data of the Storage Domain might still indicate that it is attached to a different Storage Pool.", Line 111: getParameters().getStorageDomainId(), Line 112: storagePoolId); Line 113: getReturnValue().getFault().setError(returnValue.getVdsError().getCode()); Line 114: getReturnValue().getFault().setMessage(returnValue.getVdsError().getMessage()); You need to init the Fault IIRC otherwise NPE will be thrown. Look into what's better - that or throwing vdc blll exception. Line 115: setSucceeded(false); Line 116: return; Line 117: } Line 118: -- To view, visit http://gerrit.ovirt.org/29021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie75293678ab08616208128ac157426d3d98c1b77 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
