Gilad Chaplik has posted comments on this change. Change subject: core: Adding the CpuQos entity ......................................................................
Patch Set 4: Code-Review-1 (3 comments) http://gerrit.ovirt.org/#/c/27662/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/CpuQos.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/CpuQos.java: Line 17: message = "ACTION_TYPE_FAILED_QOS_OUT_OF_RANGE_VALUES") Line 18: private Integer cpuLimit; Line 19: Line 20: @Override Line 21: public int valuesHashCode() { old code ? Line 22: final int prime = 31; Line 23: int result = super.hashCode(); Line 24: result = prime * result + ((cpuLimit == null) ? 0 : cpuLimit.hashCode()); Line 25: return result; Line 25: return result; Line 26: } Line 27: Line 28: @Override Line 29: public boolean equalValues(QosBase obj) { old code ? Line 30: if (this == obj) Line 31: return true; Line 32: if (getClass() != obj.getClass()) Line 33: return false; http://gerrit.ovirt.org/#/c/27662/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java: Line 1767: @DefaultValueAttribute("false") Line 1768: PMHealthCheckEnabled, Line 1769: Line 1770: @TypeConverterAttribute(Integer.class) Line 1771: ? Line 1772: @DefaultValueAttribute("3600") Line 1773: PMHealthCheckIntervalInSec, Line 1774: Line 1775: @TypeConverterAttribute(String.class) -- To view, visit http://gerrit.ovirt.org/27662 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2134a778d70b3c9ff3e78cc38282a515250b7cf2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
