Lior Vernia has posted comments on this change. Change subject: webadmin: Interface dialog- when opening the labels scroll should be down ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28884/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.java: Line 29: Line 30: @Override Line 31: protected void onLoad() { Line 32: super.onLoad(); Line 33: scrollPanel.scrollToBottom(); Maybe this can be solved in a more generic fashion, as other widgets extending AddRemoveRowWidget suffer from a similar issue (even if a bug wasn't opened for them yet). The problem is that AddRemoveRowWidget was designed to only take care of add/removal logic, and not layout issues. So perhaps extend it by a class that sets AddRemoveRowWidget inside a ScrollPanel, e.g. ScrollableAddRemoveRowWidget, and have NicLabelWidget extend that? Also, I wouldn't call scrollPanel.scrollToBottom() from onLoad(), but rather override AddRemoveRowWidget.init() (called every time items are set), and call it from there following super.init(). Line 34: } Line 35: Line 36: @Override Line 37: protected NicLabelEditor createWidget(ListModel<String> value) { -- To view, visit http://gerrit.ovirt.org/28884 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a2d5bd7280ef98a6ac0e94c336fcc6f30666c8a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
