Liron Aravot has posted comments on this change. Change subject: core: Force detach a storage domain ......................................................................
Patch Set 8: (1 comment) see comments in patch 6 & 8 http://gerrit.ovirt.org/#/c/29021/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java: Line 91: ).getReturnValue(); Line 92: Guid storagePoolId = domainFromIrs.getSecond(); Line 93: Line 94: // If the storage domain is already related to another Storage Pool, detach it by force. Line 95: if (storagePoolId != null && !storagePoolId.toString().isEmpty()) { what's the purpose of the second check? Line 96: Line 97: // Master domain version is not relevant since force remove at DetachStorageDomainVdsCommand Line 98: // does not use it. Line 99: // Storage pool id can be empty -- To view, visit http://gerrit.ovirt.org/29021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie75293678ab08616208128ac157426d3d98c1b77 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
