Moti Asayag has posted comments on this change. Change subject: engine: Consider mac pool in data-center actions ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/28981/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java: Line 84: return; Line 85: } Line 86: } Line 87: Line 88: final Guid storagePoolId = getStoragePoolId(); please remove this line. it is unused. Line 89: Line 90: removeDataCenter(); Line 91: Line 92: getMacPoolForDataCenter().freeMacs(macsToRemove); -- To view, visit http://gerrit.ovirt.org/28981 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f988cf803bea7cbd9670b42e48f665706166795 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
