Moti Asayag has posted comments on this change. Change subject: core: introduce context pattern ......................................................................
Patch Set 37: (1 comment) http://gerrit.ovirt.org/#/c/28829/37/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java: Line 597: getVmStaticDAO().incrementDbGeneration(getVmTemplateId()); Line 598: for (VdcActionParametersBase p : getParameters().getImagesParameters()) { Line 599: Backend.getInstance().endAction(VdcActionType.CreateImageTemplate, Line 600: p, Line 601: getContext().duplicate().resetCompensationContext().resetExecutionContext().resetLock()); > how can it shorten? what is the alternative? we need first to duplicate, th you can either: getContext().duplicate().resetCompensationContext().resetExecutionContext().resetLock()); or dupContext().resetCompensationContext().resetExecutionContext().resetLock()); which does exactly the same. CommandBase.dupContext() is introduced in this patch and already being used. Line 602: } Line 603: if (reloadVmTemplateFromDB() != null) { Line 604: endDefaultOperations(); Line 605: } -- To view, visit http://gerrit.ovirt.org/28829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I310f5f77fff78b3232ee77fe63791425fd521516 Gerrit-PatchSet: 37 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
