Martin Mucha has posted comments on this change. Change subject: restapi: rest support for MacPool ......................................................................
Patch Set 13: (3 comments) answers. http://gerrit.ovirt.org/#/c/28706/13/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 1233: <xs:complexContent> Line 1234: <xs:extension base="BaseResource"> Line 1235: <xs:sequence> Line 1236: <xs:element name="allow_duplicates" type="xs:boolean" minOccurs="1"/> Line 1237: <xs:element name="default_pool" type="xs:boolean" minOccurs="0"/> > Can this be just "default"? Done (agreed on "default_pool") Line 1238: <xs:element ref="ranges" minOccurs="0" maxOccurs="1"/> Line 1239: </xs:sequence> Line 1240: </xs:extension> Line 1241: </xs:complexContent> Line 1280: Line 1281: <xs:simpleType name="MacAddress"> Line 1282: <xs:restriction base="xs:string"> Line 1283: <xs:pattern value="([:xdigit:]{2}(:)){5}[:xdigit:]{2}"/> Line 1284: </xs:restriction> > Don't use "restriction", the generators of the SDKs won't understand it. Done Line 1285: </xs:simpleType> Line 1286: Line 1287: Line 1288: <!-- Data Centers --> http://gerrit.ovirt.org/#/c/28706/13/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java: Line 490: Line 491: private void addMacPoolsFeature(Features features) { Line 492: Feature feature = new Feature(); Line 493: feature.setName("Mac Pools"); Line 494: feature.setDescription("Configuring mac address pools for data centers"); > I think that "mac" should be upper case in the message. Done Line 495: features.getFeature().add(feature); Line 496: } -- To view, visit http://gerrit.ovirt.org/28706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id343433198dadd209933b69012303c51acb4c1e1 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
