Ramesh N has posted comments on this change. Change subject: gluster: update task details in stop remove brick ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/24319/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CommitRemoveGlusterVolumeBricksCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CommitRemoveGlusterVolumeBricksCommand.java: Line 86: } Line 87: Line 88: protected void endStepJobCommitted() { Line 89: endStepJob(JobExecutionStatus.FINISHED, getStepMessageMap(JobExecutionStatus.FINISHED, " "), true); Line 90: } I will replace " " with null as it is already taken care in getStepMessageMap() method. Line 91: Line 92: @Override Line 93: protected Map<String, String> getStepMessageMap(JobExecutionStatus status, String jobInfo) { Line 94: Map<String, String> stepMessageMap = super.getStepMessageMap(status, jobInfo); -- To view, visit http://gerrit.ovirt.org/24319 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I90be6a98470f0cb72bc7508f2cb2364f77e02077 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
