Yair Zaslavsky has posted comments on this change. Change subject: core: Add minimal tests to XmlUtils ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29083/1/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/XmlUtilsTest.java File backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/XmlUtilsTest.java: Line 31: Line 32: @Parameters Line 33: public static List<Object[]> data() { Line 34: List<Object[]> params = new ArrayList<>(); Line 35: for (int i = 2; i < 10; ++i) { probably missing something, any reason to start with 2? Line 36: params.add(new Object[]{i, String.valueOf(RandomUtils.instance().nextInt())}); Line 37: } Line 38: return params; Line 39: } -- To view, visit http://gerrit.ovirt.org/29083 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81c895335dae1ca370320e4dd437dc5da8ba36cd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
