Martin Mucha has uploaded a new change for review.
Change subject: core: coverity issue fix.
......................................................................
core: coverity issue fix.
- inlined variable, which can be null from static analysis point of
view, but such scenario would be a bug in system. Inlining variable
should convince coverity not to consider this as a problem.
Change-Id: I6751881c8b72e400f898ddd631b34106742db3b8
Signed-off-by: Martin Mucha <mmu...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacsStorage.java
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/55/29155/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacsStorage.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacsStorage.java
index e000616..fcd90ca 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacsStorage.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacsStorage.java
@@ -64,8 +64,7 @@
final List<Long> result = new ArrayList<>(numberOfMacs);
int remainingMacs = numberOfMacs;
while (remainingMacs > 0) {
- final Range rangeWithAvailableMac = getRangeWithAvailableMac();
- final List<Long> allocatedMacs =
rangeWithAvailableMac.allocateMacs(remainingMacs);
+ final List<Long> allocatedMacs =
getRangeWithAvailableMac().allocateMacs(remainingMacs);
remainingMacs -= allocatedMacs.size();
result.addAll(allocatedMacs);
--
To view, visit http://gerrit.ovirt.org/29155
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6751881c8b72e400f898ddd631b34106742db3b8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmu...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
